Conversation
yangxinxin-7
commented
Mar 17, 2026
- Fix OV_CONF undefined reference (runtime crash)
- Fix installSkill() silently swallowing errors
- Add concurrency guard for init() to prevent double server start
- Drop redundant --config ~/.openviking/ov.conf (it's the default path)
- Remove legacy openviking-context.ts (caused double system prompt injection in local plugin mode)
- Translate all messages and comments to English
|
@claude review一下 |
| // ── Skill auto-install ──────────────────────────────────────────────────────── | ||
|
|
||
| function installSkill() { | ||
| const src = join(__dirname, "skills", "openviking", "SKILL.md") |
There was a problem hiding this comment.
[Suggestion] The toast helper is defined identically here and again inside OpenVikingPlugin(). Consider extracting it into a shared factory, e.g.:
function makeToast(client) {
return (message, variant = "warning") =>
client.tui.showToast({
body: { title: "OpenViking", message, variant, duration: 8000 },
}).catch(() => {})
}Then call const toast = makeToast(client) in both places. This avoids duplication and ensures both call sites stay in sync.
| ## Error Handling | ||
|
|
||
| **`command not found: ov`** → Tell user: `pip install openviking --upgrade --force-reinstall`. Stop. | ||
| **`command not found: ov`** → Tell user: `pip install openviking --upgrade`. Stop. |
There was a problem hiding this comment.
[Suggestion] This line now reads pip install openviking --upgrade (without --force-reinstall), but README.md line 10 still says pip install openviking --upgrade --force-reinstall. Consider updating the README in this PR as well to keep both documents consistent.
| ov <command> --help # e.g. ov find --help | ||
| ``` | ||
| ov <command> --help # e.g. ov search --help | ||
| ``` No newline at end of file |
There was a problem hiding this comment.
[Suggestion] Missing newline at end of file. This causes \ No newline at end of file in diffs and doesn't conform to POSIX text file conventions. Adding a trailing newline avoids unnecessary diff noise in future changes.
- Extract toast helper into makeToast(client) to avoid duplication - Align pip install command across README and SKILL.md - Add missing newline at end of SKILL.md Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>