feat(bot):Add eval function(support locomo, skillsbench), open add-resource tool, add feishu progress notification capability#506
Merged
MaojiaSheng merged 35 commits intomainfrom Mar 10, 2026
Merged
Conversation
2. opt single turn;
# Conflicts: # bot/vikingbot/agent/loop.py # bot/vikingbot/agent/memory.py # bot/vikingbot/hooks/builtins/openviking_hooks.py
# Conflicts: # bot/vikingbot/agent/loop.py # bot/vikingbot/agent/tools/ov_file.py # bot/vikingbot/hooks/builtins/openviking_hooks.py
qin-ctx
reviewed
Mar 10, 2026
| from loguru import logger | ||
| from vikingbot.config.schema import Config | ||
|
|
||
| CONFIG_PATH = None |
Collaborator
There was a problem hiding this comment.
[Suggestion] 使用模块级全局可变变量 CONFIG_PATH 在 ensure_config() 和 load_config() 之间传递配置路径是比较脆弱的模式。多处代码(如 hooks)直接调用 load_config() 而不经过 ensure_config(),此时 CONFIG_PATH 为 None,会 fallback 到默认路径而非 CLI 传入的自定义路径。
考虑使用更显式的方式,例如将 config 对象缓存为单例,或在 load_config() 中保留 config_path 参数。
qin-ctx
reviewed
Mar 10, 2026
MaojiaSheng
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
✅ Added
🔄 Changed
🐛 Fixed
❌ Removed
Related Issue
Type of Change
Changes Made
Testing
Checklist
Screenshots (if applicable)
Additional Notes