feat(typescript): reuse module resolution cache from host#294
Merged
johnsoncodehk merged 5 commits intovolarjs:masterfrom Dec 10, 2025
Merged
feat(typescript): reuse module resolution cache from host#294johnsoncodehk merged 5 commits intovolarjs:masterfrom
johnsoncodehk merged 5 commits intovolarjs:masterfrom
Conversation
This was referenced Dec 9, 2025
|
The project version is updated on every keystroke. So, Performance-wise, it is better to do it only when the files in the project actually change. In TypeScript's TSServer, this is done by tracking a list of files that were tried in module resolution. But to do that properly, it might need quite a lot of changes. Alternatively, only tracking changes in project files might be a good enough compromise. Just feel like the original issue is an edge case, so it can wait for a fix without a big performance penalty. |
Contributor
Author
|
Thanks for catching that. I did misunderstand the project version, just fixed. |
Co-authored-by: Johnson Chu <johnsoncodehk@gmail.com>
b35d0ce to
4a33a34
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related vuejs/language-tools#5818
Review reference:
getImpliedNodeFormatForFileWorkerparampackageJsonInfoCachetype allowsundefined