Revert #49: production tarball corruption after deploy#50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #49. Right after that PR deployed, pnpm started failing to install
@voidzero-dev/vite-plus-corepreview builds from this bridge:That points at corrupted/truncated tarball bytes, and #49 rewrote the
byte-assembly logic in
fetchUpstreamTarball(the buffer this previewpackage's on-demand build path streams the upstream download into before
repacking). Reverting to restore service while the actual defect gets a
proper root-cause fix backed by a reproduction test.
Test plan
pnpm typecheckpnpm test(77/77, back to the pre-Reduce per-request CPU/memory in workspace-package check and tarball fetch #49 baseline)mainis empty