Skip to content
This repository was archived by the owner on Jun 2, 2026. It is now read-only.

MacOS IDE build#91

Merged
andrewpareles merged 1 commit into
voideditor:mainfrom
jcommaret:macos-build
Oct 7, 2024
Merged

MacOS IDE build#91
andrewpareles merged 1 commit into
voideditor:mainfrom
jcommaret:macos-build

Conversation

@jcommaret

Copy link
Copy Markdown
Contributor

No description provided.

@@ -272,7 +272,6 @@
"@types/node": "^22.5.1",
"@types/react": "^18.3.4",
"@types/react-dom": "^18.3.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't able to build the extension without this. The fix should be to downgrade this version to 1.89.0 since that's the vscode engine version the project is using.

Suggested change
"@types/react-dom": "^18.3.0",
"@types/react-dom": "^18.3.0",
"@types/vscode": "^1.89.0",

@andrewpareles andrewpareles merged commit 2b47e97 into voideditor:main Oct 7, 2024
@LeoLiuYan

Copy link
Copy Markdown

Cool~

@jcommaret jcommaret deleted the macos-build branch October 8, 2024 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants