This repository was archived by the owner on Jun 2, 2026. It is now read-only.
Merge changes from vscode disabling mangling#374
Merged
Conversation
* disable mangling when building vscode locally * local build: ensure mangling runs when minification is on
Contributor
Author
|
Todo, test all platforms compiling to verify speedup |
Contributor
Author
|
Speed up is massive, went from ~18 hours down to 5 mins for macos packaging. Seeing similar gains for linux packaging. Test compiled versions will be uploaded to https://ghostoverflow.gay/void-editor |
Contributor
|
Looks promising, will take a look at this. Just have to make sure this is compatible with our current build pipeline. |
Contributor
|
Looks great! |
Contributor
|
This breaks our build pipeline so will be reverting for now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per title