This repository was archived by the owner on Jun 2, 2026. It is now read-only.
Updated version argument to get voidVersion#364
Merged
Conversation
Contributor
|
Small question about the fallback version - should we just not fallback? What happens if we do fallback, does it still work? |
Collaborator
Author
Nope it wouldn't work because the version in our binaries is based on voidVersion not the base vscode version. I just added the fallback to not lose the original code haha but we can get rid of it. |
Contributor
|
Oh got it, happy to just comment it out then |
Collaborator
Author
Ok updated it! |
Contributor
|
Great stuff! |
Contributor
|
Just need to figure out what command opens SSH now so we can add it to the splash screen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed serverConfig.ts to pull voidVersion instead of version (vscode base version) and if not available fall back on original functionality.