This repository was archived by the owner on Jun 2, 2026. It is now read-only.
fix(build): fixes void-reh (remote host) build crashes and updates the remote-host output path to say void rather than vscode#278
Merged
Conversation
… and changed destination folder to say void
Contributor
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 6f6f43c in 21 seconds
More details
- Looked at
12lines of code in1files - Skipped
2files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. remote/package.json:36
- Draft comment:
Verify that the added 'tslib' version (^2.8.1) is compatible with other dependencies, especially with @microsoft/applicationinsights-core-js. This change fixes the npm error, but please confirm version alignment across packages. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%
None
2. remote/package.json:36
- Draft comment:
Added missing 'tslib' dependency (^2.8.1) to address the npm error. Confirm that this version meets the requirements of packages like @microsoft/applicationinsights-core-js. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%
None
Workflow ID: wflow_9DOqmHu3Ea6zajDN
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fixes bugs related to compiling and building void-server or the remote host to be used by open-remote-ssh extension by
Error: Command failed: npm ls --all --omit=dev --parseable npm ERR! code ELSPROBLEMS npm ERR! extraneous: @parcel/node-addon-api@ /Users/joaquincoromina/projects/void/react-ssh-extension/void/remote/node_modules/@parcel/node-addon-api npm ERR! missing: tslib@*, required by @microsoft/applicationinsights-core-js@2.8.15which can be replicated by running
npm ls --all --omit=dev --parseablein /remoteIssue:
Partially addresses #209 by fixing the compilation process of the void remote host which can then be included in the output files of void-remote-updates, and used by the Remote-SSH extension.
Important
Fixes build issues by adding
tslibdependency and updates output directory naming tovoid-rehinremote/package.json.tslibdependency toremote/package.jsonto resolve missing dependency error during build.vscode-reh-{{PLATFORM}}-{{ARCH}}tovoid-reh-{{PLATFORM}}-{{ARCH}}.This description was created by
for 6f6f43c. It will automatically update as commits are pushed.