This repository was archived by the owner on Jun 2, 2026. It is now read-only.
pass build information to extension#142
Merged
Merged
Conversation
Contributor
|
What are the results? |
Contributor
Author
|
This is consoled on debug console @andrewpareles |
Contributor
|
I'm worried that process.env.BUILD_ENV and process.env.BUILD_NUMBER aren't reliable. Any idea how to make them have intended behavior? If not, you can just change them to strings ('development' and '1.0.0' for now). Can you remove vinyl-fs and fix formatting? |
Contributor
Author
|
hi @andrewpareles , how do you want the formatting to be? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is related to #115