python3-Cython: fix memory leak + debug output for generators#46553
Merged
ahesford merged 1 commit intovoid-linux:masterfrom Oct 10, 2023
Merged
python3-Cython: fix memory leak + debug output for generators#46553ahesford merged 1 commit intovoid-linux:masterfrom
ahesford merged 1 commit intovoid-linux:masterfrom
Conversation
cython/cython#5690 cython/cython#5725 Both are merged in cython 3.0.3, however that release breaks scipy.
Contributor
Author
|
Alternatively, we could try updating to 3.0.3 + cython/cython#5752 which claims to fix the scipy build regression. I haven't tested that one though. Edit: or just wait for 3.0.4. This only affects sagemath with cython 3 which is not what we ship. I already have patched cython in my development box. As long as this is fixed by the time sagemath 10.2 is released (cython 3 only), we'll be fine. |
Member
|
Thanks for digging into this. Because you know this fixes issues with sagemath, let's take these patches for now and wait to see if Cython 3.0.4 fixes SciPy builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cython/cython#5690
cython/cython#5725
Both are merged in cython 3.0.3, however that release breaks scipy.
Testing the changes
The memory leak was detected due to 3 doctest failures in sagemath (when built with cython 3) and this PR fixes it.
The debug output issue symptom is that sagemath can't be built unless one sets
SAGE_DEBUG=no(however, this only triggers whenpython3-lxmlis installed).cc: @ahesford