Skip to content

gap: update to 4.12.2#41572

Merged
leahneukirchen merged 1 commit intovoid-linux:masterfrom
fingolfin:patch-2
Feb 13, 2023
Merged

gap: update to 4.12.2#41572
leahneukirchen merged 1 commit intovoid-linux:masterfrom
fingolfin:patch-2

Conversation

@fingolfin
Copy link
Copy Markdown
Contributor

Testing the changes

  • I tested the changes in this PR: NO

CC @tornaria

@tornaria
Copy link
Copy Markdown
Contributor

Looks an easy upgrade, but it has to be tested with sagemath, i.e. run sage -tp --all --long with this package installed. Be warned that there will be a few failures due to deprecation warnings in numpy 1.24 which can be ignored (I already have a patch, I'm planning to revbump sagemath 9.7 with upgraded fplll, gap, giac, igraph, pari and brial rebuilt for boost).

@classabbyamp classabbyamp added the needs-testing Testing a PR or reproducing an issue needed label Jan 12, 2023
@tornaria
Copy link
Copy Markdown
Contributor

tornaria commented Feb 2, 2023

@fingolfin: a minor nitpick, something changed in make install for headers. In 4.12.1 it would install a symlink src -> . in /usr/include/gap/. But in 4.12.2 it actually creates a directory and duplicates all the files. Is there a reason for this change?

The update seems to work ok with our sagemath 9.7.

@fingolfin
Copy link
Copy Markdown
Contributor Author

Reason for the change: the Debian maintainer complained about the symlink, implying this would cause all kinds of potential problems... In the end, I really don't care much either way :-). Longterm I hope we can get rid of this hack anyway, perhaps already in GAP 4.13.

@tornaria
Copy link
Copy Markdown
Contributor

tornaria commented Feb 3, 2023

Reason for the change: the Debian maintainer complained about the symlink, implying this would cause all kinds of potential problems... In the end, I really don't care much either way :-). Longterm I hope we can get rid of this hack anyway, perhaps already in GAP 4.13.

Ok, so we might as well rm -rf the whole redundant thing (and maybe redo the symlink) in post_install(). Or maybe just ignore, gap-4.12.2 is saving 120MB because datafiles are compressed so 1MB of redundant header files is nothing...

@leahneukirchen leahneukirchen merged commit ff6ee5e into void-linux:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-testing Testing a PR or reproducing an issue needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants