Skip to content

eva: bump revision and update checksum#40280

Merged
classabbyamp merged 1 commit intovoid-linux:masterfrom
jcgruenhage:eva-0.3.0_1
Nov 2, 2022
Merged

eva: bump revision and update checksum#40280
classabbyamp merged 1 commit intovoid-linux:masterfrom
jcgruenhage:eva-0.3.0_1

Conversation

@jcgruenhage
Copy link
Copy Markdown
Contributor

@jcgruenhage jcgruenhage commented Nov 1, 2022

Checksum changed since this was packaged. Does a revbump for stuff like this make sense? Probably not, right?

Upstream re-released v0.3.0, so the builds fail with bad checksum right now.

Testing the changes

  • I tested the changes in this PR: YES

@classabbyamp
Copy link
Copy Markdown
Member

did the contents of the tarball change?

@jcgruenhage
Copy link
Copy Markdown
Contributor Author

I don't know whether the contents changed, I don't have an old checkout lying around...

@classabbyamp
Copy link
Copy Markdown
Member

I don't know whether the contents changed, I don't have an old checkout lying around...

https://sources.voidlinux.org/eva-0.3.0/v0.3.0.tar.gz

@jcgruenhage
Copy link
Copy Markdown
Contributor Author

Okay, yeah, the contents did change, and quite a bit. Reformatting, dependency updates, lots of new tests, functionality changes. This would mean we do also do a revbump here?

@tranzystorekk
Copy link
Copy Markdown
Contributor

Maybe we could persuade upstream to make a proper new release number and just skip this?

@jcgruenhage
Copy link
Copy Markdown
Contributor Author

That would just cause work for the maintainers of nixpkgs and Arch, who've already "dealt" with this by bumping a revision number though.

@tranzystorekk
Copy link
Copy Markdown
Contributor

Ah, nevermind then, I was thinking maybe upstream have something on master branch worth a tiny patch bump, sth like that

@pickfire
Copy link
Copy Markdown
Contributor

pickfire commented Nov 2, 2022

Sorry for the retag, but I can do a version bump if needed.

@tranzystorekk
Copy link
Copy Markdown
Contributor

@pickfire I think as @jcgruenhage mentioned, a version bump would work if there are any meaningful changes left to be released, otherwise we just create churn for other distros, and I believe we can do a revision bump on our end for now

Upstream re-released v0.3.0, so the builds fail with bad checksum right
now.
@jcgruenhage jcgruenhage changed the title eva: fix checksum eva: bump revision and update checksum Nov 2, 2022
@classabbyamp classabbyamp merged commit 58d4e99 into void-linux:master Nov 2, 2022
@jcgruenhage jcgruenhage deleted the eva-0.3.0_1 branch November 3, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants