This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Update original cast resource even on reconciliation error#474
Merged
mamachanko merged 2 commits intovmware-labs:mainfrom Jan 24, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
==========================================
+ Coverage 60.67% 60.87% +0.20%
==========================================
Files 26 26
Lines 2543 2546 +3
==========================================
+ Hits 1543 1550 +7
+ Misses 911 909 -2
+ Partials 89 87 -2 ☔ View full report in Codecov by Sentry. |
400b6d1 to
8a49026
Compare
mamachanko
approved these changes
Jan 24, 2024
Collaborator
mamachanko
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing this issue, @LittleBaiBai!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #473