This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Remove generic bits from types that are not generic#448
Merged
scothis merged 1 commit intovmware-labs:mainfrom Oct 23, 2023
scothis:not-generic
Merged
Remove generic bits from types that are not generic#448scothis merged 1 commit intovmware-labs:mainfrom scothis:not-generic
scothis merged 1 commit intovmware-labs:mainfrom
scothis:not-generic
Conversation
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #448 +/- ##
=======================================
Coverage 60.65% 60.65%
=======================================
Files 26 26
Lines 2524 2524
=======================================
Hits 1531 1531
Misses 904 904
Partials 89 89 ☔ View full report in Codecov by Sentry. |
mamachanko
approved these changes
Oct 23, 2023
Collaborator
mamachanko
left a comment
There was a problem hiding this comment.
My bad. That was an oversight. Thanks for adjusting!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.