This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Switch ResourceManager update cache to JSON Patch#442
Merged
scothis merged 1 commit intovmware-labs:mainfrom Oct 11, 2023
scothis:rm-patch
Merged
Switch ResourceManager update cache to JSON Patch#442scothis merged 1 commit intovmware-labs:mainfrom scothis:rm-patch
scothis merged 1 commit intovmware-labs:mainfrom
scothis:rm-patch
Conversation
It was previously using JSON Merge Patch, which will recreate structures that are trying to be deleted. JSON Patch will fail to apply the patch if the structure being patched doesn't exist. For example, if a reconciler defined a volume on a Deployment on create/update a mutating webhook will default the file permissions. If the reconciler later needs to remove that volume, the defaulted file permissions will no longer be re-applied. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #442 +/- ##
==========================================
- Coverage 60.72% 60.65% -0.07%
==========================================
Files 26 26
Lines 2518 2524 +6
==========================================
+ Hits 1529 1531 +2
- Misses 902 904 +2
- Partials 87 89 +2
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was previously using JSON Merge Patch, which will recreate structures that are trying to be deleted. JSON Patch will fail to apply the patch if the structure being patched doesn't exist.
For example, if a reconciler defined a volume on a Deployment on create/update a mutating webhook will default the file permissions. If the reconciler later needs to remove that volume, the defaulted file permissions will no longer be re-applied.