This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Allow errors to be quiet#429
Merged
scothis merged 1 commit intovmware-labs:mainfrom Sep 6, 2023
scothis:quiet-errs
Merged
Conversation
ErrQuiet errors are not logged within reconciler-runtime and do not trigger events to be recorded. This behavior is conventional rather than technical. An implementor may choose to ignore these conventions when it fits their purpose. Quite is not silent. Also redefines ErrHaltSubReconcilers to wrap ErrQuiet. HaltSubReconcilers is deprecated in favor of ErrHaltSubReconcilers. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 60.89% 61.09% +0.19%
==========================================
Files 26 26
Lines 2514 2529 +15
==========================================
+ Hits 1531 1545 +14
- Misses 896 898 +2
+ Partials 87 86 -1
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ErrQuiet errors are not logged within reconciler-runtime and do not trigger events to be recorded. This behavior is conventional rather than technical. An implementor may choose to ignore these conventions when it fits their purpose. Quite is not silent.
Also redefines ErrHaltSubReconcilers to wrap ErrQuiet. HaltSubReconcilers is deprecated in favor of ErrHaltSubReconcilers.