This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Track managed resources when update is skipped#421
Merged
scothis merged 1 commit intovmware-labs:mainfrom Aug 31, 2023
scothis:track-without-update
Merged
Track managed resources when update is skipped#421scothis merged 1 commit intovmware-labs:mainfrom scothis:track-without-update
scothis merged 1 commit intovmware-labs:mainfrom
scothis:track-without-update
Conversation
The tracked resources need to be refreshed on each reconcile request. Previously, the ResourceManager would only track resource when they are created or updated. Now it will always track existing resources and will not be skipped when the update is skipped because the resource is in sync. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
=======================================
Coverage 60.78% 60.78%
=======================================
Files 25 25
Lines 2494 2494
=======================================
Hits 1516 1516
Misses 893 893
Partials 85 85
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked resources need to be refreshed on each reconcile request. Previously, the ResourceManager would only track resource when they are created or updated. Now it will always track existing resources and will not be skipped when the update is skipped because the resource is in sync.