This repository was archived by the owner on Aug 28, 2024. It is now read-only.
ChildSetReconciler as a dynamic composition of ChildReconcilers#396
Merged
scothis merged 2 commits intovmware-labs:mainfrom Jul 28, 2023
scothis:child-set-sketch
Merged
ChildSetReconciler as a dynamic composition of ChildReconcilers#396scothis merged 2 commits intovmware-labs:mainfrom scothis:child-set-sketch
scothis merged 2 commits intovmware-labs:mainfrom
scothis:child-set-sketch
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
+ Coverage 59.52% 61.36% +1.84%
==========================================
Files 16 17 +1
Lines 2127 2275 +148
==========================================
+ Hits 1266 1396 +130
- Misses 780 796 +16
- Partials 81 83 +2
☔ View full report in Codecov by Sentry. |
LittleBaiBai
approved these changes
Jul 26, 2023
LittleBaiBai
suggested changes
Jul 27, 2023
Delegates to dynamically created ChildReconcilers where the real business logic lives. Desired child resources defined by the reconciler based on the reconciled resource along with existing child resources discovered from the K8s API are combined where each is processed by a ChildReconciler. Signed-off-by: Scott Andrews <andrewssc@vmware.com> Co-authored-by: Bella Bai <bellab@vmware.com>
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
LittleBaiBai
approved these changes
Jul 28, 2023
Contributor
Author
|
Thanks for helping drive this @LittleBaiBai |
This was referenced Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying the concepts from #382 by composing existing reconcilers.