This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Track resources with a label selector#367
Merged
scothis merged 3 commits intovmware-labs:mainfrom May 12, 2023
scothis:track-selector
Merged
Track resources with a label selector#367scothis merged 3 commits intovmware-labs:mainfrom scothis:track-selector
scothis merged 3 commits intovmware-labs:mainfrom
scothis:track-selector
Conversation
Update tracker package to the latest from knative.dev/pkg/tracker, and then heavily modified to remove dependence on Knative packages and align with controller-runtime. The Tracker can now track resources by name or by selector. The Everything selector along with an empty namespace can be used to implicitly track all resource of a given type. The Tracker#TrackReference method can specify either a name or selector used to match resource. The Tracker#TrackObject method is a convenience method to convert a client.Object into a tracker.Reference. Similar to the existing Config#TrackAndGet method, there is a new Config#TrackAndList method that follows the contract for client.List while also tracking resources matching the query. Direct users of the Tracker will need to adapt to the new interface, however, indirect uses (like reconciler tests) are preserved. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #367 +/- ##
==========================================
+ Coverage 58.12% 59.74% +1.61%
==========================================
Files 14 16 +2
Lines 1956 2124 +168
==========================================
+ Hits 1137 1269 +132
- Misses 741 773 +32
- Partials 78 82 +4
☔ View full report in Codecov by Sentry. |
mamachanko
approved these changes
May 9, 2023
Collaborator
mamachanko
left a comment
There was a problem hiding this comment.
hits approve button multiples times
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Collaborator
|
Thanks a lot for implementing this, @scothis! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update tracker package to the latest from knative.dev/pkg/tracker, and then heavily modified to remove dependence on Knative packages and align with controller-runtime.
The Tracker can now track resources by name or by selector. The Everything selector along with an empty namespace can be used to implicitly track all resource of a given type.
The Tracker#TrackReference method can specify either a name or selector used to match resource. The Tracker#TrackObject method is a convenience method to convert a client.Object into a tracker.Reference.
Similar to the existing Config#TrackAndGet method, there is a new Config#TrackAndList method that follows the contract for client.List while also tracking resources matching the query.
Direct users of the Tracker will need to adapt to the new interface, however, indirect uses (like reconciler tests) are preserved.