This repository was archived by the owner on Aug 28, 2024. It is now read-only.
Allow ChildReconciler to stash in ReflectChildStatusOnParent#363
Merged
scothis merged 1 commit intovmware-labs:mainfrom Apr 29, 2023
scothis:child-status-stash
Merged
Allow ChildReconciler to stash in ReflectChildStatusOnParent#363scothis merged 1 commit intovmware-labs:mainfrom scothis:child-status-stash
scothis merged 1 commit intovmware-labs:mainfrom
scothis:child-status-stash
Conversation
ChildReconciler#ReflectChildStatusOnParent now accepts a context object so the values from the child resource can be stashed for subsequent reconcilers. This is common when the child needs to be referenced by another resource, but it is also not desired to expose the child directly on the parent resource. This is a breaking change, although it is easy to adapt to. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #363 +/- ##
=======================================
Coverage 58.12% 58.12%
=======================================
Files 14 14
Lines 1956 1956
=======================================
Hits 1137 1137
Misses 741 741
Partials 78 78
☔ View full report in Codecov by Sentry. |
mamachanko
approved these changes
Apr 28, 2023
Collaborator
mamachanko
left a comment
There was a problem hiding this comment.
Thanks for the swift turnaround!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChildReconciler#ReflectChildStatusOnParent now accepts a context object so the values from the child resource can be stashed for subsequent reconcilers. This is common when the child needs to be referenced by another resource, but it is also not desired to expose the child directly on the parent resource.
This is a breaking change, although it is easy to adapt to.