Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

Determinism of IdentifyChild is confusing #481

@squeedee

Description

@squeedee

Describe the bug

  • given a set of resources on cluster oc
  • when I process the KnownChildren (which is oc) and produce desired children dc (one-to-one for this example)
  • then my IdentifyChild should work regardless of on-cluster mutations during the reconcile.

Because the ResourceManager lists and filters the resources via the client again, at the point of .Manage - it loads a possibly mutated resource and uses that for that last IdentifyChild

This leads to surprising results, because I take the guidance in the docs:

// Non-deterministic IDs will result in the rapid deletion and creation of child resources.

to mean deterministic for the data passed to this reconcile

We were able to find a more "stable" form of identity, however it took a long time to discover the issue because of our assumptions about the data passed into the reconcile.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions