refactor: enhance resource pool handling#665
Merged
tenthirtyam merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
04721c5 to
c95569a
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Enhances the `FindResourcePool` method to handle resource pool name input more robustly and adds comprehensive tests for these scenarios. The changes improve how resource pool paths are resolved, handle errors more gracefully, and ensure whitespace in names is managed correctly. Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
c95569a to
08cac7f
Compare
spacegospod
approved these changes
Feb 26, 2026
|
This functionality has been released in v2.1.2 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhances the
FindResourcePoolmethod to handle resource pool name input more robustly and adds comprehensive tests for these scenarios. The changes improve how resource pool paths are resolved, handle errors more gracefully, and ensure whitespace in names is managed correctly.FindResourcePoolinresource_pool.goto trim whitespace from thenameparameter and handle absolute, relative, and empty resource pool names, improving flexibility and correctness when resolving resource pool paths.niland improved error messages for better debugging.resource_pool_test.goto cover empty names with host or cluster, relative and absolute paths, and whitespace trimming, ensuring the new logic is thoroughly validated.stringspackage inresource_pool.goto support whitespace trimming and path processing.Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Resolves #657
Release Note
Additional Information