chore(deps): downgrade sdk from 0.6.5 to v6.0.0#653
Conversation
- Downgrades `github.com/hashicorp/packer-plugin-sdk` from 0.6.5 to v6.0.0. - Downgrades `github.com/hashicorp/hcl/v2` from v2.24.0 to v2.19.1. - Downgrades `go` from 1.24.13 to 1.23.12. Ref: #651 Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR aims to resolve the export {} HCL validation regression reported in #651 by reverting/downgrading dependency versions (notably packer-plugin-sdk and hcl/v2) and adjusting the generated HCL2 specs for directory_permission.
Changes:
- Downgrade Go/module dependencies (Go version,
packer-plugin-sdk,hcl/v2, and related transitive deps). - Update generated HCL2 specs so
directory_permissionis treated as an optional numeric attribute and can decode into a nullableFileMode. - Update docs to reflect the new Go version (but also introduces doc regressions in SSH tunnel fields).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Downgrades core deps and Go version directive. |
| go.sum | Rewrites dependency sums to match downgraded module graph. |
| builder/vsphere/common/step_export.hcl2spec.go | Fixes directory_permission HCL type and makes the flat field nullable. |
| builder/vsphere/common/output_config.hcl2spec.go | Fixes directory_permission HCL type and makes the flat field nullable. |
| README.md | Updates documented Go requirement. |
| .go-version | Updates pinned Go toolchain version used by tooling/CI. |
| .web-docs/components/builder/vsphere-iso/README.md | Generated docs changed; SSH tunnel field descriptions removed. |
| .web-docs/components/builder/vsphere-clone/README.md | Generated docs changed; SSH tunnel field descriptions removed. |
| .web-docs/components/builder/vsphere-supervisor/README.md | Generated docs changed; SSH tunnel field descriptions removed. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - `ssh_local_tunnels` ([]string) - | ||
|
|
There was a problem hiding this comment.
The generated docs for ssh_local_tunnels lost the description/examples and now render as an empty bullet. Please restore the previous text (or fix the generator input) so users still know the expected format.
| - `ssh_local_tunnels` ([]string) - | ||
|
|
There was a problem hiding this comment.
The generated docs for ssh_local_tunnels lost the description/examples and now render as an empty bullet. Please restore the previous text (or fix the generator input) so users know the expected format (e.g., LOCAL_PORT:REMOTE_HOST:REMOTE_PORT).
| - `ssh_remote_tunnels` ([]string) - | ||
|
|
There was a problem hiding this comment.
The generated docs for ssh_remote_tunnels lost the description/examples and now render as an empty bullet. Please restore the previous text (or fix the generator input) so users still know the expected format.
| - `ssh_remote_tunnels` ([]string) - | ||
|
|
There was a problem hiding this comment.
The generated docs for ssh_remote_tunnels lost the description/examples and now render as an empty bullet. Please restore the previous text (or fix the generator input) so users still know the expected format.
| - `ssh_local_tunnels` ([]string) - | ||
|
|
There was a problem hiding this comment.
The generated docs for ssh_local_tunnels lost the description/examples and now render as an empty bullet. Please restore the previous text (or fix the generator input) so users still know the expected format.
| module github.com/vmware/packer-plugin-vsphere | ||
|
|
||
| go 1.24.13 | ||
| go 1.23.12 |
There was a problem hiding this comment.
The go directive in go.mod must be a language version (major.minor), not a patch version. go 1.23.12 will be rejected by the Go toolchain; use go 1.23 (and, if you want to pin the toolchain patch level, add a separate toolchain go1.23.12 directive).
| go 1.23.12 | |
| go 1.23 | |
| toolchain go1.23.12 |
| github.com/hashicorp/hcl/v2 v2.24.0 | ||
| github.com/hashicorp/packer-plugin-sdk v0.6.5 | ||
| github.com/hashicorp/hcl/v2 v2.19.1 | ||
| github.com/hashicorp/packer-plugin-sdk v0.6.0 |
There was a problem hiding this comment.
This change downgrades github.com/hashicorp/packer-plugin-sdk from v0.6.5 to v0.6.0, but the PR title/summary says ...to v6.0.0. Please align the PR metadata with the actual module version being used (or update go.mod if v6.0.0 was intended).
| - [Go 1.23.12][golang-install] | ||
|
|
||
| Required if building the plugin. |
There was a problem hiding this comment.
The README now lists a patch-level Go version (1.23.12). If go.mod is updated to use go 1.23 + toolchain go1.23.12, consider reflecting that here as well (e.g., document the toolchain version explicitly) to avoid confusion about which value is the module language version vs the toolchain version.
| - [Go 1.23.12][golang-install] | |
| Required if building the plugin. | |
| - [Go 1.23+][golang-install] (module language version) and Go toolchain 1.23.12 | |
| Required Go toolchain version if building the plugin (see `go.mod`). |
| - `ssh_remote_tunnels` ([]string) - | ||
|
|
There was a problem hiding this comment.
The generated docs for ssh_remote_tunnels lost the description/examples and now render as an empty bullet. This is a documentation regression; please restore the previous text (or adjust the doc generation input so the field comment is included) so users still know the expected format (e.g., REMOTE_PORT:LOCAL_HOST:LOCAL_PORT).
|
This functionality has been released in v2.1.1 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary
Addresses #651 where the update to
github.com/hashicorp/packer-plugin-sdkcaused issues with the export configuration. To address this immediately and issue a patch release this pull request includes the following:github.com/hashicorp/packer-plugin-sdkfrom 0.6.5 to v6.0.0.github.com/hashicorp/hcl/v2from v2.24.0 to v2.19.1.gofrom 1.24.13 to 1.23.12.Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Ref: #651
Release Note
Additional Information