Conversation
Post-transfer removal of artifact headers. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR removes HashiCorp copyright and license headers from two configuration files as part of post-transfer cleanup activities.
Changes:
- Removed SPDX license identifier and example file comments from
.goreleaser.yml - Removed HashiCorp copyright and SPDX license identifier from
.golangci.yml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .goreleaser.yml | Removed SPDX-License-Identifier header and example file comments; file now starts with YAML document separator |
| .golangci.yml | Removed HashiCorp copyright and SPDX-License-Identifier header; file now starts with YAML document separator |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # This is an example goreleaser.yaml file with some defaults. | ||
| # Make sure to check the documentation at http://goreleaser.com | ||
| --- |
There was a problem hiding this comment.
This PR removes HashiCorp copyright headers from these two files, but several other files in the repository still contain similar HashiCorp copyright headers, including:
.github/workflows/build_plugin_binaries.yml.github/workflows/go-validate.yml.github/release.yml.github/actions/build-and-persist-plugin-binary/action.yml
If the goal is to remove artifact headers post-transfer (as indicated by the PR description), consider whether these other files should also be updated for consistency. If these files are intentionally being kept with headers, the PR description could be clarified to explain which specific files are being updated and why.
|
|
||
| # This is an example goreleaser.yaml file with some defaults. | ||
| # Make sure to check the documentation at http://goreleaser.com | ||
| --- |
There was a problem hiding this comment.
The removed comment "This is an example goreleaser.yaml file with some defaults. Make sure to check the documentation at http://goreleaser.com" provides context about the file's origin and references documentation. While this may be considered boilerplate, it's not strictly a license header. If the intent is only to remove license/copyright headers, consider whether this informational comment should be retained.
|
This functionality has been released in v2.1.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
1 similar comment
|
This functionality has been released in v2.1.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Summary
Post-transfer removal of artifact headers.
Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Release Note
Additional Information