Merged
Conversation
Post-transfer update of the module namespace and refs. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the module namespace and all internal references from the previous HashiCorp-owned path to the new VMware-owned path for the vsphere Packer plugin.
Changes:
- Update the
go.modmodule path togithub.com/vmware/packer-plugin-vsphere. - Replace all internal imports referencing
github.com/hashicorp/packer-plugin-vsphere/...withgithub.com/vmware/packer-plugin-vsphere/.... - Adjust example, test, builder, datasource, and post-processor packages to use the new module namespace consistently.
Reviewed changes
Copilot reviewed 79 out of 79 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testing/vsphere/acceptance.go | Update test imports to use the new vmware module namespace. |
| post-processor/vsphere/post-processor.go | Update vsphere driver import path to the vmware namespace. |
| post-processor/vsphere-template/step_mark_as_template.go | Update vsphere post-processor import to the vmware namespace. |
| post-processor/vsphere-template/step_create_snapshot.go | Update vsphere post-processor import to the vmware namespace. |
| post-processor/vsphere-template/post-processor.go | Update common vsphere and post-processor imports to the vmware namespace. |
| main.go | Point all builder, datasource, post-processor, and version imports to the vmware module path. |
| go.mod | Change the module path to github.com/vmware/packer-plugin-vsphere. |
| examples/driver/main.go | Update example driver imports to use vmware namespace. |
| datasource/virtualmachine/filters.go | Update vsphere driver import to the vmware namespace. |
| datasource/virtualmachine/data_test.go | Update common and testing vsphere imports to the vmware namespace. |
| datasource/virtualmachine/data.go | Update common vsphere and driver imports to the vmware namespace. |
| builder/vsphere/supervisor/utils_test.go | Update supervisor builder import to vmware namespace. |
| builder/vsphere/supervisor/step_watch_source_test.go | Update supervisor builder import to vmware namespace. |
| builder/vsphere/supervisor/step_validate_publish_test.go | Update supervisor builder import to vmware namespace. |
| builder/vsphere/supervisor/step_publish_source_test.go | Update supervisor builder import to vmware namespace. |
| builder/vsphere/supervisor/step_import_image_test.go | Update supervisor builder import to vmware namespace. |
| builder/vsphere/supervisor/step_create_source_test.go | Update supervisor builder import to vmware namespace. |
| builder/vsphere/supervisor/step_connect_supervisor_test.go | Update supervisor builder import to vmware namespace. |
| builder/vsphere/supervisor/config_test.go | Update supervisor config import to vmware namespace. |
| builder/vsphere/supervisor/config.go | Update common vsphere config import to vmware namespace. |
| builder/vsphere/supervisor/builder.go | Update common vsphere builder import to vmware namespace. |
| builder/vsphere/iso/step_create_test.go | Update common and driver imports in ISO step tests to vmware namespace. |
| builder/vsphere/iso/step_create.hcl2spec.go | Update common vsphere import in hcl2 spec to vmware namespace. |
| builder/vsphere/iso/step_create.go | Update common vsphere and driver imports in ISO step implementation. |
| builder/vsphere/iso/config.hcl2spec.go | Update common vsphere import in ISO config spec. |
| builder/vsphere/iso/config.go | Update common vsphere config import for ISO builder. |
| builder/vsphere/iso/builder_acc_test.go | Update utils and testing vsphere imports in ISO acceptance tests. |
| builder/vsphere/iso/builder.go | Update common vsphere and driver imports in ISO builder. |
| builder/vsphere/driver/vm_create_acc_test.go | Update common utils import in VM create acceptance tests. |
| builder/vsphere/driver/vm_clone_acc_test.go | Update common utils import in VM clone acceptance tests. |
| builder/vsphere/driver/host_acc_test.go | Update common utils import in host acceptance tests. |
| builder/vsphere/driver/driver_test.go | Update common utils import in driver tests to vmware namespace. |
| builder/vsphere/common/vcenter_simulator_test.go | Update driver import in vCenter simulator tests. |
| builder/vsphere/common/step_wait_for_ip.go | Update driver import in wait-for-IP step. |
| builder/vsphere/common/step_template.go | Update driver import in template-conversion step. |
| builder/vsphere/common/step_ssh_key_pair.go | Update driver import in SSH key pair step. |
| builder/vsphere/common/step_snapshot.go | Update driver import in snapshot step. |
| builder/vsphere/common/step_shutdown.go | Update driver import in shutdown step. |
| builder/vsphere/common/step_run.go | Update driver import in run step. |
| builder/vsphere/common/step_resolve_datastore_test.go | Update driver import in datastore resolution tests. |
| builder/vsphere/common/step_resolve_datastore.go | Update driver import in datastore resolution step. |
| builder/vsphere/common/step_remove_network_adapter_test.go | Update driver import in remove network adapter tests. |
| builder/vsphere/common/step_remove_network_adapter.go | Update driver import in remove network adapter step. |
| builder/vsphere/common/step_remove_floppy_test.go | Update driver import in remove floppy tests. |
| builder/vsphere/common/step_remove_floppy.go | Update driver import in remove floppy step. |
| builder/vsphere/common/step_remove_cdrom_test.go | Update driver import in remove CD-ROM tests. |
| builder/vsphere/common/step_remove_cdrom.go | Update driver import in remove CD-ROM step. |
| builder/vsphere/common/step_remote_upload_test.go | Update driver import in remote upload tests. |
| builder/vsphere/common/step_remote_upload.go | Update driver import in remote upload step. |
| builder/vsphere/common/step_reattach_cdrom_test.go | Update driver import in reattach CD-ROM tests. |
| builder/vsphere/common/step_reattach_cdrom.go | Update driver import in reattach CD-ROM step. |
| builder/vsphere/common/step_import_to_content_library.go | Update driver import in content library import step. |
| builder/vsphere/common/step_hardware_test.go | Update driver import in hardware config tests. |
| builder/vsphere/common/step_hardware.go | Update driver import in hardware config step. |
| builder/vsphere/common/step_export.go | Update driver import in export step. |
| builder/vsphere/common/step_download_test.go | Update driver import in download tests. |
| builder/vsphere/common/step_download.go | Update driver import in download step. |
| builder/vsphere/common/step_connect.go | Update driver import in connect step. |
| builder/vsphere/common/step_config_params.go | Update driver import in config params step. |
| builder/vsphere/common/step_boot_command.go | Update driver import in boot command step. |
| builder/vsphere/common/step_add_floppy_test.go | Update driver import in add floppy tests. |
| builder/vsphere/common/step_add_floppy.go | Update driver import in add floppy step. |
| builder/vsphere/common/step_add_flag_test.go | Update driver import in add flag tests. |
| builder/vsphere/common/step_add_flag.go | Update driver import in add flag step. |
| builder/vsphere/common/step_add_cdrom_test.go | Update driver import in add CD-ROM tests. |
| builder/vsphere/common/step_add_cdrom.go | Update driver import in add CD-ROM step. |
| builder/vsphere/common/hcp_metadata_test.go | Update driver import in HCP metadata tests. |
| builder/vsphere/common/hcp_metadata.go | Update driver import in HCP metadata logic. |
| builder/vsphere/common/cleanup_vm_test.go | Update driver import in cleanup VM tests. |
| builder/vsphere/common/cleanup_vm.go | Update driver import in cleanup VM helper. |
| builder/vsphere/common/artifact_test.go | Update driver import in artifact tests. |
| builder/vsphere/common/artifact.go | Update driver import in artifact implementation. |
| builder/vsphere/clone/step_customize.go | Update driver import in clone customization step. |
| builder/vsphere/clone/step_clone_test.go | Update common and driver imports in clone step tests. |
| builder/vsphere/clone/step_clone.hcl2spec.go | Update common vsphere import in clone hcl2 spec. |
| builder/vsphere/clone/step_clone.go | Update common vsphere and driver imports in clone step. |
| builder/vsphere/clone/config.hcl2spec.go | Update common vsphere import in clone config spec. |
| builder/vsphere/clone/config.go | Update common vsphere config import in clone builder. |
| builder/vsphere/clone/builder.go | Update common vsphere and driver imports in clone builder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This functionality has been released in v2.1.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
1 similar comment
|
This functionality has been released in v2.1.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Post-transfer update of the module namespace and refs.