chore(deps): bump actions in build-and-persist-plugin-binary#600
chore(deps): bump actions in build-and-persist-plugin-binary#600tenthirtyam merged 1 commit intomainfrom
build-and-persist-plugin-binary#600Conversation
Update actions versions in `build-and-persist-plugin-binary` workflow: - `actions/checkout` from v4.1.4 to v6.0.2 - `actions/upload-artifact` from v4.3.3 to v6.0.0 Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions versions in the build-and-persist-plugin-binary workflow, but also includes an undocumented and apparently incorrect plugin name change from vsphere to vmware.
Changes:
- Updates
actions/checkoutfrom v4.1.4 to v6.0.2 - Updates
actions/upload-artifactfrom v4.3.3 to v6.0.0 - Changes plugin name from
packer_plugin_vspheretopacker_plugin_vmwarethroughout (not mentioned in PR description) - Adds blank lines after the action name and inputs section
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | ||
| shell: bash | ||
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | ||
| with: | ||
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | ||
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
There was a problem hiding this comment.
The plugin name has been changed from packer_plugin_vsphere to packer_plugin_vmware, but this appears to be incorrect. The go.mod (line 1) clearly shows this is github.com/hashicorp/packer-plugin-vsphere, and the README differentiates this plugin from packer-plugin-vmware (README.md lines 33-52). This change will cause the zip file to have an incorrect name.
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | ||
| shell: bash | ||
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | ||
| with: | ||
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | ||
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
There was a problem hiding this comment.
The plugin name has been changed from packer_plugin_vsphere to packer_plugin_vmware, but this appears to be incorrect. The go.mod (line 1) clearly shows this is github.com/hashicorp/packer-plugin-vsphere, and the README differentiates this plugin from packer-plugin-vmware (README.md lines 33-52). This change will cause the binary removal to target the wrong file.
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | ||
| shell: bash | ||
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | ||
| with: | ||
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | ||
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
There was a problem hiding this comment.
The artifact name has been changed from packer_plugin_vsphere to packer_plugin_vmware, but this appears to be incorrect. The go.mod (line 1) clearly shows this is github.com/hashicorp/packer-plugin-vsphere, and the README differentiates this plugin from packer-plugin-vmware (README.md lines 33-52). This will cause artifacts to be uploaded with incorrect names, which may break downstream processes that depend on these artifacts.
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | ||
| shell: bash | ||
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | ||
| with: | ||
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | ||
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
There was a problem hiding this comment.
The artifact path has been changed from packer_plugin_vsphere to packer_plugin_vmware, but this appears to be incorrect. The go.mod (line 1) clearly shows this is github.com/hashicorp/packer-plugin-vsphere, and the README differentiates this plugin from packer-plugin-vmware (README.md lines 33-52). This will cause the action to try to upload a file that doesn't exist, as the file created in line 18 will not match this path.
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 | ||
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | ||
| shell: bash | ||
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | ||
| with: | ||
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | ||
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
There was a problem hiding this comment.
The PR description states that only action versions are being updated, but this PR also changes the plugin name from vsphere to vmware throughout the file (lines 16, 18, 20, 24, 25). This is a significant discrepancy between the stated purpose and the actual changes. If the plugin name change is intentional, the PR description should be updated to reflect this major change.
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | ||
| shell: bash | ||
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | ||
| shell: bash | ||
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | ||
| with: | ||
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | ||
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
There was a problem hiding this comment.
The plugin name has been changed from packer_plugin_vsphere to packer_plugin_vmware, but this appears to be incorrect. The go.mod (line 1) clearly shows this is github.com/hashicorp/packer-plugin-vsphere, and the README differentiates this plugin from packer-plugin-vmware (README.md lines 33-52). This change will cause the build to produce incorrectly named binaries that don't match the actual plugin name.
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vmware_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| - run: "GOOS=${{ inputs.GOOS }} GOARCH=${{ inputs.GOARCH }} go build -o ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} ." | |
| shell: bash | |
| - run: zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - run: rm ./pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }} | |
| shell: bash | |
| - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0 | |
| with: | |
| name: "packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" | |
| path: "pkg/packer_plugin_vsphere_${{ inputs.GOOS }}_${{ inputs.GOARCH }}.zip" |
|
This functionality has been released in v2.1.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
1 similar comment
|
This functionality has been released in v2.1.0 of the plugin. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Update actions versions in
build-and-persist-plugin-binaryworkflow:actions/checkoutfrom v4.1.4 to v6.0.2actions/upload-artifactfrom v4.3.3 to v6.0.0