refactor: set firmware configuration during create#579
Merged
Conversation
032c55b to
cfa8f79
Compare
8db430a to
96b7dce
Compare
Refactors to support for specifying the firmware type when creating and configuring the virtual machines. This will ensure that the APCI layout for virtual machines created with virtual hardware 20 or later with EFI (and EFI with Secure Boot) have the correct APCI motherboard layout upon creation. Reference: - https://knowledge.broadcom.com/external/article/313466/ - https://williamlam.com/2023/01/acpi-motherboard-layout-requires-efi-considerations-for-switching-vm-firmware-in-vsphere-8.html Signed-off-by: Ryan Johnson <rya@tenthirtyam.org>
96b7dce to
34fa2bd
Compare
2 tasks
kp2099
approved these changes
Dec 15, 2025
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors to support for specifying the firmware type when creating and configuring the virtual machines. This will ensure that the APCI layout for virtual machines created with virtual hardware 20 or later with EFI (and EFI with Secure Boot) have the correct APCI motherboard layout upon creation.
Reference:
Resolved Issues
Closes #472
Rollback Plan
Revert commit.
Changes to Security Controls
None.