Skip to content

refactor: clone example#572

Merged
kp2099 merged 1 commit intomainfrom
refactor/clone-example
Nov 19, 2025
Merged

refactor: clone example#572
kp2099 merged 1 commit intomainfrom
refactor/clone-example

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Description

Refactors the vsphere-clone example for Alpine.

  • Variable ordering.
  • Missing variable (datastore)
  • Remove unused variables (guest_os_type)

Resolved Issues

Example is not operable with the missing datastore attribute.

Rollback Plan

Revert commit.

Changes to Security Controls

None.

Refactors the `vsphere-clone` example for Alpine.

- Variable ordering.
- Missing variable (`datastore`)
- Remove unused variables (`guest_os_type`)

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Oct 14, 2025
@tenthirtyam tenthirtyam self-assigned this Oct 14, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 14, 2025 17:44
Copilot AI review requested due to automatic review settings October 14, 2025 17:44
@tenthirtyam tenthirtyam added builder/vsphere-clone Builder: vsphere-clone refactor Refactor labels Oct 14, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the Alpine vsphere-clone example to make it operational by adding a missing required datastore configuration and improving code organization. The changes include removing an unused guest_os_type variable, reordering variables and source block attributes for better clarity, and adding the previously missing datastore variable and attribute.

Key Changes:

  • Added missing datastore variable and corresponding attribute in the source block
  • Removed unused guest_os_type variable
  • Reordered variables and source block attributes for improved organization

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tenthirtyam tenthirtyam requested a review from kp2099 October 16, 2025 23:21
@kp2099 kp2099 merged commit 4e363a5 into main Nov 19, 2025
14 checks passed
@kp2099 kp2099 deleted the refactor/clone-example branch November 19, 2025 09:22
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

builder/vsphere-clone Builder: vsphere-clone refactor Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants