Skip to content

refactor: constants and comments#564

Merged
kp2099 merged 2 commits intomainfrom
refactor/constants-and-comments
Oct 16, 2025
Merged

refactor: constants and comments#564
kp2099 merged 2 commits intomainfrom
refactor/constants-and-comments

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Description

Grouped related constants into a single const block and improved comments for clarity in post-processor/vsphere/post-processor.go.

Rollback Plan

Revert commit.

Changes to Security Controls

None.

@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Oct 6, 2025
@tenthirtyam tenthirtyam self-assigned this Oct 6, 2025
@tenthirtyam tenthirtyam added technical-debt Technical Debt post-processor/vsphere Post-Processor: vsphere refactor Refactor labels Oct 6, 2025
@tenthirtyam tenthirtyam force-pushed the refactor/constants-and-comments branch 2 times, most recently from 8d4ce99 to f751db1 Compare October 6, 2025 19:19
@tenthirtyam tenthirtyam marked this pull request as ready for review October 6, 2025 19:25
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 6, 2025 19:25
Copilot AI review requested due to automatic review settings October 6, 2025 19:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors constants and improves comments in the VSphere post-processor. The changes focus on code organization and clarity without affecting functionality.

  • Grouped three individual constant declarations into a single const block
  • Improved comment clarity and grammar throughout the file
  • Removed redundant inline comments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Grouped related constants into a single `const` block and improved comments for clarity in `post-processor/vsphere/post-processor.go`.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the refactor/constants-and-comments branch from f751db1 to b838199 Compare October 6, 2025 20:13
@tenthirtyam tenthirtyam requested a review from Copilot October 6, 2025 20:14
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@tenthirtyam tenthirtyam requested a review from kp2099 October 13, 2025 16:01
@kp2099 kp2099 merged commit c28c445 into main Oct 16, 2025
14 checks passed
@kp2099 kp2099 deleted the refactor/constants-and-comments branch October 16, 2025 11:18
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

post-processor/vsphere Post-Processor: vsphere refactor Refactor technical-debt Technical Debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants