adding go.mod file reference to actions/setup-go#563
Conversation
|
@kp2099 This change should work but can we make it more in sync with other github actions we have? Declare the |
|
Wouldn't go.mod be more accurate since that's essentially the source of truth? |
I’m not sure why the extra step was added initially, but actions/setup-go already supports using a .go-version file as the source for the Go version. Since go.mod and .go-version should ideally be in sync, we can simply point setup-go to the .go-version file: With this approach, there’s no need for a separate step just to read the Go version, the setup action handles it automatically. I have tested it locally and here is a ref comment as well. And as @tenthirtyam pointed out go.mod should be the actual source of truth in my opinion |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Currently,
actions/setup-gois not aligned with the Go version specified in the project, which causes thenotify-integration-releasestep to use a different Go version. This mismatch leads tomake generatefailing and prevents documentation from being published to the developer website.This change updates actions/setup-go to automatically read the Go version from the project's go.mod file, ensuring consistency and preventing build failures.
I have tested this change locally using
act, and i have attached screenshots for the same