fix: always apply hardware configuration by tenthirtyam · Pull Request #561 · vmware/packer-plugin-vsphere

tenthirtyam · 2025-09-15T02:13:51Z

Description

Only set non-zero or enabled fields, preventing unnecessary changes.
Always applies the configuration to ensure template settings are preserved.

packer-plugin-vsphere on  fix/always-apply-hardware-configuration [$] via 🐹 v1.23.11 
➜ go test ./...
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        0.325s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       1.430s
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/utils [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       3.461s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  1.091s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   6.509s
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       0.829s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      1.095s
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]

packer-plugin-vsphere on  fix/always-apply-hardware-configuration [$] via 🐹 v1.23.11 
➜ go test -v ./builder/vsphere/common -run TestStepConfigureHardware_Run  
=== RUN   TestStepConfigureHardware_Run
=== RUN   TestStepConfigureHardware_Run/Configure_hardware
2025/10/14 09:21:46 ui: Customizing hardware...
=== RUN   TestStepConfigureHardware_Run/Configure_hardware_even_when_config_is_empty_(preserves_template_settings)
2025/10/14 09:21:46 ui: Applying hardware configuration...
=== RUN   TestStepConfigureHardware_Run/Halt_when_configure_return_error
2025/10/14 09:21:46 ui: Customizing hardware...
--- PASS: TestStepConfigureHardware_Run (0.00s)
    --- PASS: TestStepConfigureHardware_Run/Configure_hardware (0.00s)
    --- PASS: TestStepConfigureHardware_Run/Configure_hardware_even_when_config_is_empty_(preserves_template_settings) (0.00s)
    --- PASS: TestStepConfigureHardware_Run/Halt_when_configure_return_error (0.00s)
PASS
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       0.307s

Resolved Issues

Closes #522

Rollback Plan

Revert commit.

Changes to Security Controls

None.

Copilot

Pull Request Overview

This PR fixes hardware configuration to always run even when the hardware config is empty, ensuring template settings are preserved during VM provisioning.

Removes the check that skipped hardware configuration when config was empty
Adds a helper method to determine if custom hardware config is provided to display appropriate UI messages
Updates test to verify hardware configuration runs even with empty config

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
builder/vsphere/common/step_hardware.go	Implements logic to always run hardware configuration and adds helper method to detect custom config
builder/vsphere/common/step_hardware_test.go	Updates test case to verify hardware configuration runs with empty config

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

builder/vsphere/common/step_hardware.go

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

builder/vsphere/common/step_hardware.go

Copilot

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

builder/vsphere/common/step_hardware.go

builder/vsphere/driver/vm.go

- Only set non-zero or enabled fields, preventing unnecessary changes. - Always applies the configuration to ensure template settings are preserved. Signed-off-by: Ryan Johnson <rya@tenthirtyam.org>

github-actions · 2026-01-29T01:35:57Z

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

tenthirtyam added this to the v2.1.0 milestone Sep 15, 2025

tenthirtyam self-assigned this Sep 15, 2025

tenthirtyam added bug Bug refactor Refactor labels Sep 15, 2025

tenthirtyam force-pushed the fix/always-apply-hardware-configuration branch from f86aa22 to dd7e68c Compare October 6, 2025 19:01

tenthirtyam force-pushed the fix/always-apply-hardware-configuration branch from dd7e68c to bfdf005 Compare October 14, 2025 00:27

tenthirtyam added the builder/vsphere-clone Builder: vsphere-clone label Oct 14, 2025

tenthirtyam marked this pull request as ready for review October 14, 2025 12:47

tenthirtyam requested a review from a team as a code owner October 14, 2025 12:47

Copilot AI review requested due to automatic review settings October 14, 2025 12:47