Skip to content

refactor: remove deprecated ui.Message#538

Merged
tenthirtyam merged 1 commit intomainfrom
refactor/remove-deprecated-ui.Message
Jun 5, 2025
Merged

refactor: remove deprecated ui.Message#538
tenthirtyam merged 1 commit intomainfrom
refactor/remove-deprecated-ui.Message

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented May 23, 2025

Replaces the SDK-deprecated ui.Message in the with ui.Say and ui.Sayf as applicable.

~/Downloads/packer-plugin-vsphere git:[refactor/remove-deprecated-ui.Message]
go fmt ./...

post-processor/vsphere-template/step_mark_as_template.go
~/Downloads/packer-plugin-vsphere git:[refactor/remove-deprecated-ui.Message]
make build

~/Downloads/packer-plugin-vsphere git:[refactor/remove-deprecated-ui.Message]
make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.763s
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/utils [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.701s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       8.489s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  2.798s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   9.870s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       2.176s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      3.897s

@tenthirtyam tenthirtyam added this to the v2.0.0 milestone May 23, 2025
@tenthirtyam tenthirtyam self-assigned this May 23, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner May 23, 2025 14:35
@tenthirtyam tenthirtyam added technical-debt Technical Debt refactor Refactor labels May 23, 2025
@tenthirtyam
refactor: remove deprecated ui.Message
c132f67 
Replaces the deprecated `ui.Message` with `ui.Say` and `ui.Sayf` as applicable.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the refactor/remove-deprecated-ui.Message branch from 0d24bd4 to c132f67 Compare May 23, 2025 21:56
@tenthirtyam tenthirtyam merged commit c90c267 into main Jun 5, 2025
13 checks passed
@tenthirtyam tenthirtyam deleted the refactor/remove-deprecated-ui.Message branch June 5, 2025 14:33
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 29, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JenGoldstrich JenGoldstrich Awaiting requested review from JenGoldstrich

1 more reviewer

@kp2099 kp2099 kp2099 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

refactor Refactor technical-debt Technical Debt

Projects

None yet

Milestone

v2.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @kp2099