Skip to content

fix: http_ip warn vs err#475

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
fix/httpip-intf-warn
Oct 15, 2024
Merged

fix: http_ip warn vs err#475
lbajolet-hashicorp merged 1 commit intomainfrom
fix/httpip-intf-warn

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Updates ValidateHTTPAddress to simply log a warning if the http_ip is not bound to an interface instead of error.

Closes #474

Updates `ValidateHTTPAddress` to simply log a warning if the `http_ip` is not bound to an interface instead of error.

Ref: #474

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added bug Bug refactor Refactor labels Oct 9, 2024
@tenthirtyam tenthirtyam added this to the v1.4.1 milestone Oct 9, 2024
@tenthirtyam tenthirtyam self-assigned this Oct 9, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner October 9, 2024 20:45
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit bd61340 into main Oct 15, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix/httpip-intf-warn branch October 15, 2024 18:07
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Bug refactor Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to use http_ip when running in a container

2 participants