Merged
Conversation
- o := &types.OptionValue{...} ensures OptionValue is correctly type-asserted to BaseOptionValue.
- Added more descriptive error messages for better debugging.
- Updated documentation.
Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
lbajolet-hashicorp
approved these changes
Oct 4, 2024
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
LGTM! Thanks @tenthirtyam
1 task
1 task
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates to the documentation, improvements to logging, and enhancements to error handling in the
vspherebuilder components. The most important changes include adding examples to the documentation, improving logging for configuration parameters, and enhancing error handling during VM reconfiguration.Documentation Updates:
.web-docs/components/builder/vsphere-clone/README.md: Added HCL and JSON examples forconfiguration_parametersand notes on ignored keys..web-docs/components/builder/vsphere-iso/README.md: Added HCL and JSON examples forconfiguration_parametersand notes on ignored keys.docs-partials/builder/vsphere/common/ConfigParamsConfig-not-required.mdx: Added HCL and JSON examples forconfiguration_parametersand notes on ignored keys.Logging Enhancements:
builder/vsphere/common/step_config_params.go: Added logging for each key-value pair inconfiguration_parameters.Error Handling Improvements:
builder/vsphere/driver/vm.go: Enhanced error messages and added logging for ignored configuration parameters during VM reconfiguration.Testing
Configuration:
Log:
Reference
Ref: #467