Skip to content

fix: remove ovftool commands from logs#462

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
fix/remove-ovftool-commands-from-logs
Aug 26, 2024
Merged

fix: remove ovftool commands from logs#462
lbajolet-hashicorp merged 1 commit intomainfrom
fix/remove-ovftool-commands-from-logs

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Aug 22, 2024

Summary

Removes the joined commands which would contain credentials, if logged.

Testing

packer-plugin-vsphere on  fix/remove-ovftool-commands-from-logs via 🐹 v1.23.0 
➜ go fmt ./...

packer-plugin-vsphere on  fix/remove-ovftool-commands-from-logs via 🐹 v1.23.0 
➜ make test   
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.606s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       4.567s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       9.782s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  5.977s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   11.874s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       4.912s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      6.166s

Reference

@tenthirtyam
fix: remove ovftool commands from logs
6162750 
Removes the joined commands which would contain credentials, if logged.

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam added this to the v1.5.0 milestone Aug 22, 2024
@tenthirtyam tenthirtyam self-assigned this Aug 22, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 22, 2024 01:04
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Aug 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 7ce9641 into main Aug 26, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix/remove-ovftool-commands-from-logs branch August 26, 2024 15:37
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 30, 2026

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

technical-debt Technical Debt

Projects

None yet

Milestone

v1.4.1

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @lbajolet-hashicorp