Skip to content

chore: update supervisor plugin example jenkins template#447

Merged
nywilken merged 1 commit intovmware:mainfrom
dilyar85:update-supervisor-jeknins-template
Jun 25, 2024
Merged

chore: update supervisor plugin example jenkins template#447
nywilken merged 1 commit intovmware:mainfrom
dilyar85:update-supervisor-jeknins-template

Conversation

@dilyar85
Copy link
Copy Markdown
Member

@dilyar85 dilyar85 commented Jun 23, 2024 •
edited
Loading

Description

This PR updates the Supervisor builder example template to install a newer JDK version.
The current JDK version (11) is no longer supported by the latest Jenkins release (2.426.1):

packer@jenkins-test:~$ jenkins
Running with Java 11 from /usr/lib/jvm/java-11-openjdk-amd64, which is older than the minimum required version (Java 17).
Supported Java versions are: [17, 21]

Testing

The Packer command ran successfully using the updated template file:

$ packer build jenkins-template.pkr.hcl
vsphere-supervisor.vm: output will be in this color.

==> vsphere-supervisor.vm: Creating temporary RSA SSH key for instance...
    vsphere-supervisor.vm: Connecting to Supervisor cluster...
    ...
    vsphere-supervisor.vm: Source VM is now ready in Supervisor cluster
    ...
==> vsphere-supervisor.vm: Provisioning with shell script: /var/folders/nf/cndlm4ts2bd9jz3dd667jfb80000gr/T/packer-shell3086856209
    ...
==> vsphere-supervisor.vm: + sudo apt-get -qq -o Acquire::ForceIPv4=true install -f -y ca-certificates openjdk-21-jre-headless
    ...
    vsphere-supervisor.vm: Completed sample-job #1 : SUCCESS
    vsphere-supervisor.vm: Skip cleaning up the VirtualMachinePublishRequest object as specified in config
    vsphere-supervisor.vm: Skip cleaning up the source objects as specified in config
    vsphere-supervisor.vm: Build 'vsphere-supervisor' finished successfully.
Build 'vsphere-supervisor.vm' finished after 3 minutes 17 seconds.

==> Wait completed after 3 minutes 17 seconds

==> Builds finished but no artifacts were created.

Reference

https://www.jenkins.io/doc/book/platform-information/support-policy-java/#java-support-policy

@dilyar85 dilyar85 requested a review from a team as a code owner June 23, 2024 17:36
@tenthirtyam tenthirtyam requested a review from nywilken June 23, 2024 17:53
akutz
akutz approved these changes Jun 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@akutz akutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @dilyar85 !

@tenthirtyam tenthirtyam added the chore Chore label Jun 24, 2024
@tenthirtyam tenthirtyam added this to the v1.3.1 milestone Jun 24, 2024
@nywilken nywilken added the docs label Jun 25, 2024
nywilken
nywilken approved these changes Jun 25, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for keeping the examples updated.

@nywilken nywilken merged commit b80a946 into vmware:main Jun 25, 2024
@vmware vmware locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@akutz akutz akutz approved these changes

@tenthirtyam tenthirtyam tenthirtyam approved these changes

+1 more reviewer

@nywilken nywilken nywilken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dilyar85 dilyar85

Labels

chore Chore

Projects

None yet

Milestone

v1.4.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dilyar85 @akutz @nywilken @tenthirtyam