Skip to content

🚧 feat: add support for reusing a vm#439

Closed
Hi-Angel wants to merge 2 commits intovmware:mainfrom
npobaum:reuse-vm
Closed

🚧 feat: add support for reusing a vm#439
Hi-Angel wants to merge 2 commits intovmware:mainfrom
npobaum:reuse-vm

Conversation

@Hi-Angel
Copy link
Copy Markdown
Contributor

@Hi-Angel Hi-Angel commented Jun 18, 2024

This PR resolves the problem where users could not install a system from ISO to a pre-created Virtual Machine.

Closes #334

TODO:

  • Error out if HCL/JSON config has reuse_vm = true and also hardware configuration (because we don't want to modify hw on a pre-created VM). under discussion

This will be useful later to add editDevice() that would share most of
the code with adddevice().
@Hi-Angel Hi-Angel requested a review from a team as a code owner June 18, 2024 15:25
@Hi-Angel
Copy link
Copy Markdown
Contributor Author

This is rebased version of closed PR. The feature is currently under discussion per this comment

@tenthirtyam tenthirtyam marked this pull request as draft June 18, 2024 15:34
@tenthirtyam tenthirtyam added this to the Backlog milestone Jun 18, 2024
@tenthirtyam
Copy link
Copy Markdown
Collaborator

Go Validate / Generate check (pull_request) Failing after 1m

Needs to run make generate and amend the commit.

This adds a new configuration option `ReuseVM` that allows to reuse an
existing virtual machine instead of creating a new one. Hardware
setup in the config will be ignored in such case.
@Hi-Angel
Copy link
Copy Markdown
Contributor Author

Oh, I'm sorry, I haven't realized the message Docs have been updated, but the compiled docs have not been committed is an actual error. Seeing auto-generated things get commited isn't typical, so I dismissed the message and in absence of any other error I thought it's just a CI bug.

Done! Should be okay now

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Hi @Hi-Angel! 👋

Since there haven't been any reactions on this niche use case (nor seen in other plugins), we're going to decline this feature gracefully as not planned. You are of course welcome to fork the project and use the implementation for your environmental needs.

Ryan Johnson
Distinguished Engineer, VMware by Broadcom

@tenthirtyam tenthirtyam removed this from the Backlog milestone Oct 15, 2024
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement Enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for reusing a virtual machine

2 participants