fix: don't assume driver isn't nil in StepConnect#437
Merged
Conversation
When attempting to cleanup the existing connections to the VSphere cluster, we get the driver from the state shared between all steps in order to run the commands necessary for that. This can however fail, if the step couldn't succeed for any reason. Then, if the connection fails and the driver isn't set in the state, when running Cleanup on the connect step, we get the driver from state and cast it to a driver.Driver. This will make the plugin crash, and so we change how we proceed here, by getting the driver with a `GetOk`, exiting if it failed to be fetched from state, then casting the result if it was created in state. This should prevent crashes like those.
tenthirtyam
reviewed
May 30, 2024
tenthirtyam
reviewed
May 30, 2024
tenthirtyam
approved these changes
May 30, 2024
Collaborator
tenthirtyam
left a comment
There was a problem hiding this comment.
LGTM - just let a couple nits for the messages.
Co-authored-by: Ryan Johnson <johnsonryan@vmware.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When attempting to cleanup the existing connections to the VSphere cluster, we get the driver from the state shared between all steps in order to run the commands necessary for that.
This can however fail, if the step couldn't succeed for any reason.
Then, if the connection fails and the driver isn't set in the state, when running Cleanup on the connect step, we get the driver from state and cast it to a driver.Driver.
This will make the plugin crash, and so we change how we proceed here, by getting the driver with a
GetOk, exiting if it failed to be fetched from state, then casting the result if it was created in state.This should prevent crashes like those.
Closes: #436