Merged
Conversation
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
The change looks good to me! I'm a bit surprised at the amount of doc changes that are melded in one commit, there's a lot in there.
Would you be ok to split the PR in two commits? One for the doc improvements, and one for the command fix? That'd be easier to understand the scope of the change here.
Collaborator
Author
|
Sure, I can happily split it out today. |
Updates RunOnceCommandList to a slice of strings `[]string` and updates 'guiRunOnce()` to pass "" if no commands are provided. This will ensure that the function addresses each case. Ref: #419 Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
10382f1 to
2a31f38
Compare
Collaborator
Author
|
Simplified in 2a31f38, @lbajolet-hashicorp. |
lbajolet-hashicorp
approved these changes
May 10, 2024
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
LGTM, thanks for the split!
Collaborator
Author
|
Posted the other half of the split from the original commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
RunOnceCommandListto a slice of strings[]stringand updatesguiRunOnce()to pass""if no commands are provided. This will ensure that the function addresses each case.Testing
Basic:
Scenarios:
✅
run_once_command_listnot provided.✅
run_once_command_list []used.✅
run_once_command_list [""]used.✅
run_once_command_list ["command1", "command2"]used.Reference
Closes #419