chore(deps): bump github.com/vmware/govmomi from 0.36.2 to 0.37.1#422
Merged
lbajolet-hashicorp merged 1 commit intomainfrom May 9, 2024
Merged
chore(deps): bump github.com/vmware/govmomi from 0.36.2 to 0.37.1#422lbajolet-hashicorp merged 1 commit intomainfrom
lbajolet-hashicorp merged 1 commit intomainfrom
Conversation
- Updates `vmware/govmom` from 0.36.2 to 0.37.1. - Due to a change in 0.37.0 of `vmware/govmom`, the `ReconfigureFail` needed to be removed. The CreateTask method in the TaskManager struct was updated. The new method now checks if the provided TaskTypeId is valid before proceeding. If it's not valid, it returns a SOAP fault with an InvalidArgument error. Ref: vmware/govmomi@9c59e9c#diff-b69f2c4e19456b811639643ed5dfe09357a280ac81b47249a14d6e625ef46317 Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
lbajolet-hashicorp
approved these changes
May 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vmware/govmomfrom 0.36.2 to 0.37.1.vmware/govmom, theReconfigureFailneeded to be removed. The CreateTask method in the TaskManager struct was updated. The new method now checks if the provided TaskTypeId is valid before proceeding. If it's not valid, it returns a SOAP fault with an InvalidArgument error.Testing
Reference
Ref: vmware/govmomi@9c59e9c#diff-b69f2c4e19456b811639643ed5dfe09357a280ac81b47249a14d6e625ef46317