Skip to content

feat: option to remove network adapters#415

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
feat/option-remove-network-adapters
May 9, 2024
Merged

feat: option to remove network adapters#415
lbajolet-hashicorp merged 1 commit intomainfrom
feat/option-remove-network-adapters

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Apr 27, 2024 •
edited
Loading

Summary

Adds the option to remove all network adapters at the end of the image build, including tests.

remove_network_adapter (bool) - Remove all network adapters from virtual machine image. Defaults to false.

Testing

  • Basic Tests ✅
  • End to End Tests ✅
➜  packer-plugin-vsphere git:(feat/option-remove-network-adapters) go fmt ./...
➜  packer-plugin-vsphere git:(feat/option-remove-network-adapters) make generate
2024/04/26 23:23:44 Copying "docs" to ".docs/"
2024/04/26 23:23:44 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...
➜  packer-plugin-vsphere git:(feat/option-remove-network-adapters) make build
➜  packer-plugin-vsphere git:(feat/option-remove-network-adapters) make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        3.767s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.613s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       6.401s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  4.691s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   7.646s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       3.059s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      3.980s
➜  packer-plugin-vsphere git:(feat/option-remove-network-adapters)

Reference

Closes #6

@tenthirtyam tenthirtyam added the enhancement Enhancement label Apr 27, 2024
@tenthirtyam tenthirtyam added this to the v1.2.8 milestone Apr 27, 2024
@tenthirtyam tenthirtyam self-assigned this Apr 27, 2024
@tenthirtyam tenthirtyam force-pushed the feat/option-remove-network-adapters branch 2 times, most recently from cadb278 to 300aa39 Compare April 27, 2024 03:41
@tenthirtyam tenthirtyam added builder/vsphere-iso Builder: vsphere-iso builder/vsphere-clone Builder: vsphere-clone labels Apr 28, 2024
@tenthirtyam tenthirtyam marked this pull request as ready for review April 30, 2024 18:38
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 30, 2024 18:38
@tenthirtyam tenthirtyam force-pushed the feat/option-remove-network-adapters branch from 300aa39 to ec494c0 Compare May 9, 2024 13:49
@tenthirtyam
feat: option to remove network adapters
3a062ae 
Adds the option to remove all network adapters at the end of the image build.

Ref: #6

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the feat/option-remove-network-adapters branch from ec494c0 to 3a062ae Compare May 9, 2024 14:15
@lbajolet-hashicorp lbajolet-hashicorp merged commit 64f3180 into main May 9, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the feat/option-remove-network-adapters branch May 9, 2024 14:41
@vmware vmware locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nywilken nywilken Awaiting requested review from nywilken

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

builder/vsphere-clone Builder: vsphere-clone builder/vsphere-iso Builder: vsphere-iso enhancement Enhancement

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

vsphere-iso: Add support for removing ethernet before export

2 participants

@tenthirtyam @lbajolet-hashicorp