Skip to content

docs: disk_size#411

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
docs/disk-size-usage
May 9, 2024
Merged

docs: disk_size#411
lbajolet-hashicorp merged 1 commit intomainfrom
docs/disk-size-usage

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Apr 19, 2024

Summary

  • Clarifies that disk_size in the vsphere-clone builder only supports a single disk.
  • Adds a TODO note for future enhancements to findDisk and ResizeDisk functions.

###Tessting

packer-plugin-vsphere1 on  docs/disk-size-usage via 🐹 v1.22.2 
➜ make generate
2024/04/18 21:14:24 Copying "docs" to ".docs/"
2024/04/18 21:14:24 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vsphere1 on  docs/disk-size-usage via 🐹 v1.22.2 took 12.5s 
➜ make build   

packer-plugin-vsphere1 on  docs/disk-size-usage via 🐹 v1.22.2 took 5.2s 
➜ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        1.908s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.869s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.798s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  1.466s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   4.109s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       2.307s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.693s

packer-plugin-vsphere1 on  docs/disk-size-usage via 🐹 v1.22.2 took 8.4s

Reference

Closes #303

@tenthirtyam
docs: disk_size
1521615 
- Clarifies that `disk_size` in the `vsphere-clone` builder only supports a single disk.
- Adds a `TODO` note for future enhancements to `findDisk` and `ResizeDisk` functions.

Ref: #303

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam added the documentation Documentation label Apr 19, 2024
@tenthirtyam tenthirtyam added this to the v1.2.8 milestone Apr 19, 2024
@tenthirtyam tenthirtyam self-assigned this Apr 19, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 19, 2024 01:16
@tenthirtyam tenthirtyam added the builder/vsphere-clone Builder: vsphere-clone label Apr 28, 2024
@lbajolet-hashicorp lbajolet-hashicorp merged commit d3dc4be into main May 9, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the docs/disk-size-usage branch May 9, 2024 13:24
@vmware vmware locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nywilken nywilken Awaiting requested review from nywilken

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

builder/vsphere-clone Builder: vsphere-clone documentation Documentation

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

vsphere-clone: unable to use disk_size when source image has multiple disks

2 participants

@tenthirtyam @lbajolet-hashicorp