feat: add support for export to ova#409
Merged
lbajolet-hashicorp merged 1 commit intomainfrom May 10, 2024
Merged
Conversation
d207291 to
24bf114
Compare
lbajolet-hashicorp
approved these changes
May 9, 2024
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Pre-approving since overall this looks good to me, just left a couple nits, but we're close to merge imo!
24bf114 to
97a2527
Compare
Collaborator
Author
|
Comments addressed in 97a2527. Running another round of tests to ensure all is still well. |
Adds support to export a virtual machine image to either to the default Open Virtualization Format (`ovf`) or convert to Open Virtualization Archive (.ova). Note: To use the `ova` format option, VMware ovftool must be installed on the Packer host and accessible in either the system `PATH` or the user's `PATH`. This is noted in the documentation. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
97a2527 to
4e2c30b
Compare
lbajolet-hashicorp
approved these changes
May 10, 2024
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the rerolls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support to export a virtual machine image to either to the default Open Virtualization Format (
ovf) or convert to Open Virtualization Archive (.ova).Note
To use the
ovaformat option, VMware ovftool must be installed on the Packer host and accessible in either the systemPATHor the user'sPATH. This is noted in the documentation.Testing
Standard Build and Tests:
Additional Tests
✅ PASS: Export without setting
Format. Defaults toovf.✅ PASS: Export without setting
Format. Defaults toovf. Expected error for existingovffile found.✅ PASS: Export without setting
Formatwithforce = true. Defaults toovf. Existingovfoverwritten.✅ PASS: Export setting
Formattoovawithoutovftoolinstalled or inPATH. Expected error.✅ PASS: Export setting
Formattoova.✅ PASS: Export setting
Formattoova. Expected error for existingovafile found and intermediate files removed.✅ PASS: Export setting
Formattoovawithforce = true. Existingovaoverwritten and intermediate files removed.Reference
Closes #17
VMware Open Virtualization Format Tool (
ovftool).