Skip to content

fix: skip unix-style permissions#404

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
fix/skip-unix-style-permissions
Apr 12, 2024
Merged

fix: skip unix-style permissions#404
lbajolet-hashicorp merged 1 commit intomainfrom
fix/skip-unix-style-permissions

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

If running on Windows, do not attempt to apply Unix-style permissions to the artifact output.

Closes #280

@tenthirtyam tenthirtyam added the technical-debt Technical Debt label Apr 12, 2024
@tenthirtyam tenthirtyam added this to the v1.2.8 milestone Apr 12, 2024
@tenthirtyam tenthirtyam self-assigned this Apr 12, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 12, 2024 03:43
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a nit, but aside from that LGTM!

@tenthirtyam tenthirtyam force-pushed the fix/skip-unix-style-permissions branch from 8c1c879 to e75a4ae Compare April 12, 2024 14:40
If running on Windows, do not attempt to apply  Unix-style permissions to the artifact output.

Ref: #280

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the fix/skip-unix-style-permissions branch from e75a4ae to 067acbf Compare April 12, 2024 14:47
@lbajolet-hashicorp lbajolet-hashicorp merged commit 0f368ae into main Apr 12, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix/skip-unix-style-permissions branch April 12, 2024 14:54
@vmware vmware locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

technical-debt Technical Debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to output file permission and ownership

2 participants