Skip to content

fix: floppy naming pattern#403

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
fix-floppy-naming-pattern
Apr 12, 2024
Merged

fix: floppy naming pattern#403
lbajolet-hashicorp merged 1 commit intomainfrom
fix-floppy-naming-pattern

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Apr 11, 2024

Summary

  • Updates the naming pattern for a generated floppy from the status packer-tmp-created-floppy.flp to a pattern of packer-##########.flp (e.g., packer-0123456789.flp.)
    • This naming pattern matches the one used by packer-sdk for generated ISOs.
  • Updates the tests to account for this change from the static name to the new pattern.

Reference

Closes #93

Testing

➜  packer-plugin-vsphere git:(main) ✗ 
➜  packer-plugin-vsphere git:(fix-floppy-naming-pattern) make generate
2024/04/11 09:28:47 Copying "docs" to ".docs/"
2024/04/11 09:28:47 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...
➜  packer-plugin-vsphere git:(fix-floppy-naming-pattern) make test    
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.685s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       4.937s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.226s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  3.501s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   8.325s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       4.817s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      4.223s
➜  packer-plugin-vsphere git:(fix-floppy-naming-pattern) make build   
➜  packer-plugin-vsphere git:(fix-floppy-naming-pattern)

@tenthirtyam tenthirtyam added the bug Bug label Apr 11, 2024
@tenthirtyam tenthirtyam added this to the v1.2.8 milestone Apr 11, 2024
@tenthirtyam tenthirtyam self-assigned this Apr 11, 2024
@tenthirtyam tenthirtyam mentioned this pull request Apr 11, 2024
Closed
@tenthirtyam tenthirtyam marked this pull request as ready for review April 11, 2024 13:59
@tenthirtyam tenthirtyam requested a review from a team as a code owner April 11, 2024 13:59
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Apr 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nit left, but overall LGTM!

@tenthirtyam tenthirtyam force-pushed the fix-floppy-naming-pattern branch from 34f3a87 to 72072ef Compare April 11, 2024 21:07
@tenthirtyam
fix: floppy naming pattern
86db58a 
- Updates the naming pattern for a generated floppy from the status `packer-tmp-created-floppy.flp` to a pattern of `packer-##########.flp`. This naming pattern matches the one used by packer-sdk for generated ISOs. This helps avoid conflicts with other floppy images that might be uploaded.
- Updates the tests to account for this change from the static name to the new pattern.

Ref: #93

Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the fix-floppy-naming-pattern branch from 72072ef to 86db58a Compare April 11, 2024 21:19
@lbajolet-hashicorp lbajolet-hashicorp merged commit 2eb1527 into main Apr 12, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the fix-floppy-naming-pattern branch April 12, 2024 15:12
@vmware vmware locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nywilken nywilken Awaiting requested review from nywilken

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

bug Bug

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

Floppy gets overwritten with multiple parallel runs

2 participants

@tenthirtyam @lbajolet-hashicorp