Merged
Conversation
ea18640 to
6a06f6a
Compare
3dd0eab to
506c31c
Compare
Contributor
|
@tenthirtyam I added this to our board for review. I should be able to review it tomorrow. |
2abe471 to
a6bbe67
Compare
a6bbe67 to
aa7d6dd
Compare
aa7d6dd to
f5f8660
Compare
Collaborator
Author
|
@nywilken @lbajolet-hashicorp - All set on this one, let me know when you have time to review and I'm happy to demo this 1:1 so you can see it in action. |
f5f8660 to
49e2846
Compare
49e2846 to
b3563dc
Compare
lbajolet-hashicorp
approved these changes
Apr 11, 2024
Contributor
lbajolet-hashicorp
left a comment
There was a problem hiding this comment.
Left a couple nits, but overall LGTM!
Collaborator
Author
|
Thanks! I'll address the comments and update you when pushed. |
dce57e1 to
69bb52f
Compare
- Adds ability to perform cleanup of items added to the remote cache upon build completion in addition to the existing cancelled or halted. To enable, set `remote_cache_cleanup = true`. Defaults to `false`. - Adds the ability to specify the datastore for the placement of the remote cache. To enable, set `remote_cache_datastore = "myCacheDatastoreName"`. If not set, the datastore of the virtual machine is used. - Adds the ability to specify the path on the datastore for the placement of the remote cache. To enable, set `remote_cache_path = "foo/bar"` If not set, the default path is `packer_cache` at the root of the datastore. - Adds the ability to overwrite items in the remote cache. To enable, set `remote_cache_overwrite = true`. - Adds the ability to overwrite items in the local cache. To enable, set `local_cache_overwrite = true`. If `local_cache_overwrite = true`, `remote_cache_overwrite` is implicitly be set to `true`. This is to ensure consistency between the local and remote cache. Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
69bb52f to
38b58fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds ability to perform cleanup of items added to the remote cache upon build completion in addition to the existing cancelled or halted.
To enable, set
remote_cache_cleanup = true. Defaults tofalse.Adds the ability to specify the datastore for the placement of the remote cache.
To enable, set
remote_cache_datastore = "myCacheDatastoreName". If not set, the datastore of the virtual machine is used.Adds the ability to specify the path on the datastore for the placement of the remote cache.
To enable, set
remote_cache_path = "foo/bar"If not set, the default path is
packer_cacheat the root of the datastore.Adds the ability to overwrite items in the remote cache.
To enable, set
remote_cache_overwrite = true.Adds the ability to overwrite items in the local cache.
To enable, set
local_cache_overwrite = true.If
local_cache_overwrite = true,remote_cache_overwriteis implicitly be set totrue. This is to ensure consistency between the local and remote cache.Testing
Example configuration:
When
remote_cache_cleanup = true:When
remote_cache_cleanup = falseor not included:And with:
remote_cache_datastore = "local-ssd-02"remote_cache_path = "bar/packer_cache"Results:
make testReference
The following is in the top 5 of most requested (open) enhancements.
Closes #14
Closes #55
Closes #88