common: make sure to prepend remote iso path#388
Merged
nywilken merged 1 commit intovmware:mainfrom Mar 19, 2024
Merged
Conversation
This fixes regression introduced by the commit
"common: deduplicate AddCdrom call by appending path to ISOPaths"
that was squashed into:
"refactor: only add / remove minimul number of cdroms (vmware#355)"
It assumed that the order is not guaranteed and does not matter,
however the documentation says:
> If the "iso_url" is defined in addition to the "iso_paths", the
> "iso_url" is added to the VM first. This keeps the "iso_url" first
> in the boot order by default allowing the boot iso being defined by
> the iso_url and the vmware tools iso added from the datastore.
So fix the regression.
Fixes: vmware#386
Signed-off-by: Konstantin Kharlamov <Hi-Angel@yandex.ru>
Contributor
Author
|
upd: added the S-b to the commit message |
Collaborator
nywilken
approved these changes
Mar 19, 2024
Contributor
nywilken
left a comment
There was a problem hiding this comment.
Thanks for the quick turnaround on this bug @Hi-Angel the changes look good to me. I see the previous version added a CDROM for the remote path to start but that is now handled later in the code when iterating through s.Config.ISOPaths. So all is good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes regression introduced by the commit
that was squashed into:
It explained that the order is not guaranteed and does not matter, however the documentation says:
So fix the regression.
Fixes: #386