Skip to content

chore(post-processor): update vsphere#387

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
chore(post-processor)/update-vsphere
Mar 19, 2024
Merged

chore(post-processor): update vsphere#387
lbajolet-hashicorp merged 1 commit intomainfrom
chore(post-processor)/update-vsphere

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Mar 18, 2024

Summary

  • Updates and simplifies code comments.
  • Updates post-processor to generate documentation from structs.
  • Generates the updated post-processor documentation.

Testing

packer-plugin-vsphere on chore(post-processor)/update-vsphere
➜ make generate
2024/03/18 11:09:48 Copying "docs" to ".docs/"
2024/03/18 11:09:48 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...

packer-plugin-vsphere on chore(post-processor)/update-vsphere
➜ make dev  

packer-plugin-vsphere on chore(post-processor)/update-vsphere 
➜ make build

packer-plugin-vsphere on chore(post-processor)/update-vsphere
➜ make test

?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.545s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.664s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       5.196s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  3.046s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   4.909s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.471s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      1.986s

@tenthirtyam tenthirtyam added post-processor/vsphere Post-Processor: vsphere chore Chore labels Mar 18, 2024
@tenthirtyam tenthirtyam added this to the v1.2.6 milestone Mar 18, 2024
@tenthirtyam tenthirtyam self-assigned this Mar 18, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner March 18, 2024 15:12
@tenthirtyam
chore(post-processor): update vsphere
64d9bef 
- Updates and simplifies code comments.
- Updates post-processor to generate documentation from structs.
- Generates the updated post-processor documentation.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the chore(post-processor)/update-vsphere branch from 15bac9d to 64d9bef Compare March 18, 2024 15:14
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Mar 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit 28b1dab into main Mar 19, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore(post-processor)/update-vsphere branch March 19, 2024 14:29
@vmware vmware locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nywilken nywilken Awaiting requested review from nywilken

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

chore Chore post-processor/vsphere Post-Processor: vsphere

Projects

None yet

Milestone

v1.2.7

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @lbajolet-hashicorp