Skip to content

chore(post-processor): update vsphere-template#385

Merged
lbajolet-hashicorp merged 1 commit intomainfrom
chore(post-processor)/update-vsphere-template
Mar 18, 2024
Merged

chore(post-processor): update vsphere-template#385
lbajolet-hashicorp merged 1 commit intomainfrom
chore(post-processor)/update-vsphere-template

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

@tenthirtyam tenthirtyam commented Mar 14, 2024

Summary

  • Updates error messages to use a more well-formed structure.
  • Updates and simplifies code comments.
  • Updates post-processor to generate documentation from structs.
  • Generates the updated post-processor documentation.

Testing

packer-plugin-vsphere on  chore(post-processor)/update-vsphere-template [$!?] via 🐹 v1.22.1 
➜ make dev


packer-plugin-vsphere on  chore(post-processor)/update-vsphere-template [$!?] via 🐹 v1.22.1 
➜ make generate
2024/03/14 14:01:06 Copying "docs" to ".docs/"
2024/03/14 14:01:06 Replacing @include '...' calls in .docs/
Compiling MDX docs in '.docs' to Markdown in '.web-docs'...


packer-plugin-vsphere on  chore(post-processor)/update-vsphere-template [$!?] via 🐹 v1.22.1 took 11.6s 
➜ make build


packer-plugin-vsphere on  chore(post-processor)/update-vsphere-template [$!?] via 🐹 v1.22.1 took 3.2s 
➜ make test
?       github.com/hashicorp/packer-plugin-vsphere      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common/testing       [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/examples/driver      [no test files]
?       github.com/hashicorp/packer-plugin-vsphere/version      [no test files]
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/clone        2.092s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/common       2.645s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/driver       6.430s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/iso  1.438s
ok      github.com/hashicorp/packer-plugin-vsphere/builder/vsphere/supervisor   4.679s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere       1.781s
ok      github.com/hashicorp/packer-plugin-vsphere/post-processor/vsphere-template      2.089s

@tenthirtyam tenthirtyam added post-processor/vsphere-template Post-Processor: vsphere-template chore Chore labels Mar 14, 2024
@tenthirtyam tenthirtyam self-assigned this Mar 14, 2024
@tenthirtyam tenthirtyam requested a review from a team as a code owner March 14, 2024 18:03
@tenthirtyam tenthirtyam force-pushed the chore(post-processor)/update-vsphere-template branch from 7d7ab07 to 2033e57 Compare March 14, 2024 18:21
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Mar 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall @tenthirtyam, I just left a couple nits, but the changes are good to go aside those

@tenthirtyam tenthirtyam force-pushed the chore(post-processor)/update-vsphere-template branch from 2033e57 to 8610889 Compare March 14, 2024 23:26
@tenthirtyam tenthirtyam added this to the v1.2.6 milestone Mar 15, 2024
@tenthirtyam tenthirtyam force-pushed the chore(post-processor)/update-vsphere-template branch 2 times, most recently from 7e55cdb to b571556 Compare March 16, 2024 04:19
@tenthirtyam
chore(post-processor): update vsphere-template
0a20b0a 
- Updates error messages to use a more well-formed structure.
- Updates and simplifies code comments.
- Updates post-processor to generate documentation from structs.
- Generates the updated post-processor documentation.

Signed-off-by: Ryan Johnson <ryan@tenthirtyam.org>
@tenthirtyam tenthirtyam force-pushed the chore(post-processor)/update-vsphere-template branch from b571556 to 0a20b0a Compare March 16, 2024 04:42
lbajolet-hashicorp
lbajolet-hashicorp approved these changes Mar 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@lbajolet-hashicorp lbajolet-hashicorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lbajolet-hashicorp lbajolet-hashicorp merged commit a236f67 into main Mar 18, 2024
@lbajolet-hashicorp lbajolet-hashicorp deleted the chore(post-processor)/update-vsphere-template branch March 18, 2024 14:04
@vmware vmware locked and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nywilken nywilken Awaiting requested review from nywilken

1 more reviewer

@lbajolet-hashicorp lbajolet-hashicorp lbajolet-hashicorp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tenthirtyam tenthirtyam

Labels

chore Chore post-processor/vsphere-template Post-Processor: vsphere-template

Projects

None yet

Milestone

v1.2.7

Development

Successfully merging this pull request may close these issues.

2 participants

@tenthirtyam @lbajolet-hashicorp