docs: update version in example#90
Merged
nywilken merged 3 commits intovmware:mainfrom Oct 12, 2022
graememeyer:patch-1
Merged
Conversation
Updated version and fixed source link
|
|
nywilken
previously requested changes
Sep 9, 2022
Contributor
nywilken
left a comment
There was a problem hiding this comment.
The updated source address for the required_plugins block is not meant to be a full GitHub URL. Please see my comments for the exact details.
tenthirtyam
requested changes
Sep 28, 2022
Collaborator
tenthirtyam
left a comment
There was a problem hiding this comment.
I'd prefer an x.y.x example semver format so that it doesn't need to be updated with each release.
Reset the path to pre-commit.
Reset to `source = "github.com/hashicorp/vmware"` Co-authored-by: Wilken Rivera <dev@wilkenrivera.com>
tenthirtyam
requested changes
Oct 7, 2022
Set `version = ">= x.y.z"` as an example so that this does not need to be continuatlly updated.
tenthirtyam
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated version to the latest 1.0.7, and fixed the source link which was pointing to a non-existence repository on GitHub.